Embedded contribution form #325

newick · 2019-06-14T13:46:52Z

Screens for https://trello.com/c/wrkki02b/142-embedded-contribution-form-sendinblue-mailjet exist.
Time to add some logic @lutangar @JalilArfaoui :)

JalilArfaoui · 2019-06-14T13:48:53Z

Thanks !

Can you rebase on develop @newick ?

src/app/content/App/CreateNoticeScreen/CreateNoticeScreen.stories.tsx

src/app/content/App/Notice/Details/Details.stories.tsx

src/app/content/App/PublishedNoticeScreen/Container.ts

src/app/content/App/PublishedNoticeScreen/Illustration.tsx

src/app/content/App/PublishedNoticeScreen/PublishedNoticeScreen.stories.tsx

src/components/atoms/icons/Alternative.tsx

src/components/molecules/IntentionsSelector/IntentionsSelectorContainer.ts

src/components/organisms/NoticeDetails/CenterContainer.ts

src/components/organisms/NoticeDetails/DetailsContainer.ts

src/components/organisms/NoticeDetails/Feedbacks.ts

JalilArfaoui · 2019-06-20T10:21:12Z

I'm opening PRs directly in this branch to build upon your work @newick ....

bmenant · 2019-06-25T09:28:53Z

Actually, as @lutangar spotted in #332 we missed the contributor name field in the form. My fault I guess. 🙏

I added a comment in the Trello card: https://trello.com/c/wrkki02b/142-embedded-contribution-form-sendinblue-mailjet

lutangar · 2019-08-05T08:07:48Z

@bmenant we need a last functional review on this.

JalilArfaoui

Some functional comments:

It seems that we're missing some space between the 2 buttons :

I have a red message whereas I'm just typing for the first time and don't have any red field :

Otherwise, seems good 👍

JalilArfaoui

Some code comments ...

webpack.config.js

src/components/atoms/Forms/Input/Input.ts

src/app/utils/form/handleFormSubmit.ts

JalilArfaoui · 2019-08-15T07:11:13Z

src/app/lmem/Errors.ts

@@ -0,0 +1,3 @@
+export default interface Errors {


Maybe this is FormError ?

This one is in our domain, FormErrors is not.

Except that, to me, what you are describing is a form error, not a general LMEM error.

Then maybe this should be outside app/lmem and be called FormErrors to be correct, no ?

src/app/lmem/contribution/validate.ts and src/app/lmem/contribution/validate.ts can be used outside of a form context, but I could move validateForm.ts outside of lmem though.
The idea was to propose an Errors interface for validation errors of a "model". The name could be better though, smthing like ValidationErrors or ModelErrors or ModelValidationErrors. What do you think?

OK, I see what you're trying to do. Maybe ValidationErrors makes it more explicit then.

src/app/content/sagas/contribution.ts

src/app/content/App/Notice/Details/withConnect.ts

src/app/content/App/Contribute/PreviewScreen/PreviewScreen.stories.tsx

lutangar · 2019-09-06T11:33:27Z

src/app/background/store/migrations/4.2019-08-28.ts

@@ -1,4 +1,4 @@
-import { PersistedState } from 'redux-persist/es/types';


WTF I just had this problem in another branch when attempting to push.... isn't that supposed to be in develop?

lutangar · 2019-09-06T11:33:59Z

src/app/content/selectors/index.ts

@@ -90,22 +89,28 @@ export const getFormRegisteredFields = (formName: string) => (
  return R.path(['registeredFields'], form) || [];
 };

+const getFieldPathErrorMessage = (state: ContentState, formName: string) => (


lutangar · 2019-09-06T11:34:06Z

src/app/content/selectors/index.ts

-    }, {})
-    .filter(errorMessage => errorMessage);
-};
+): string[] =>


lutangar · 2019-09-06T11:36:47Z

src/app/lmem/contribution/validate.spec.ts

+    expect(validateContribution()).to.not.be.empty;
+  });
+  it('rejects empty contribution', () => {
+    // @ts-ignore


So we can still use ts-ignore after all?

src/app/lmem/contribution/validate.spec.ts

add intention selector change cheap selector to efficient ones

add form elements add intention selector change cheap selector to efficient ones add `onChange` handler on `IntentionSelector`

…ection handle contribution form 1. Submit: sync validation only 2. Preview: show server error when failing 3. Submitted: removed the button to see the notice

fix preview overflow and background issues

… invalid

… fields state

…view screen if submission failed

try to clarify getFlatFormErrors fix typings issues functional style to validateContribution

bmenant · 2019-10-11T13:36:44Z

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

newick requested review from JalilArfaoui, lutangar and bmenant June 14, 2019 13:46

lutangar requested changes Jun 14, 2019

View reviewed changes

newick force-pushed the style/EmbeddedContributionForm branch from ea1785a to f018647 Compare June 14, 2019 15:06

newick self-assigned this Jun 20, 2019

JalilArfaoui mentioned this pull request Jun 20, 2019

feat(contribution): add onChange handler on IntentionSelector #327

Merged

lutangar self-requested a review June 20, 2019 09:35

lutangar approved these changes Jun 20, 2019

View reviewed changes

JalilArfaoui added showstopper WIP 👷 labels Jun 20, 2019

JalilArfaoui changed the title ~~Style/embedded contribution form~~ Embedded contribution form Jun 21, 2019

JalilArfaoui assigned lutangar and JalilArfaoui and unassigned newick Jun 21, 2019

JalilArfaoui mentioned this pull request Jun 21, 2019

feat(contribution): setup sendinblue for contribution forward #332

Merged

JalilArfaoui added this to the V3 (Bulle) - New Notification Design milestone Jun 21, 2019

lutangar force-pushed the style/EmbeddedContributionForm branch 2 times, most recently from 8464bf2 to 72b1fdb Compare July 2, 2019 08:30

lutangar force-pushed the style/EmbeddedContributionForm branch from 72b1fdb to 5aad906 Compare July 9, 2019 08:43

lutangar force-pushed the style/EmbeddedContributionForm branch 3 times, most recently from 04ba976 to 6dfff98 Compare August 4, 2019 19:51

JalilArfaoui requested changes Aug 14, 2019

View reviewed changes

JalilArfaoui requested changes Aug 15, 2019

View reviewed changes

lutangar force-pushed the style/EmbeddedContributionForm branch from a9422dd to 675f72e Compare August 16, 2019 09:25

lutangar reviewed Sep 6, 2019

View reviewed changes

src/app/content/selectors/index.ts

}, {})

.filter(errorMessage => errorMessage);

};

): string[] =>

Copy link

Member

lutangar Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lutangar reviewed Sep 6, 2019

View reviewed changes

src/app/lmem/contribution/validate.spec.ts Outdated Show resolved Hide resolved

lutangar force-pushed the style/EmbeddedContributionForm branch from 54ba871 to 978ecfc Compare September 6, 2019 12:27

newick and others added 19 commits September 6, 2019 15:29

style(Contribute): add form elements

3e692e4

add intention selector change cheap selector to efficient ones

feat(contribution): setup sendinblue for contribution forward

ce8cb82

add form elements add intention selector change cheap selector to efficient ones add `onChange` handler on `IntentionSelector`

feat(form): add redux-form

2091ba0

feat(form): add Fields adapter

ee2a8ea

feat(submit-notice): implement submit notice screen and success redir…

e188cb5

…ection handle contribution form 1. Submit: sync validation only 2. Preview: show server error when failing 3. Submitted: removed the button to see the notice

fix(sendinblue): handle all 2xx codes

aecbf0a

chore(forms): refactor with new conventions

835646e

fix preview overflow and background issues

fix(stories): fix AddNoticeLink story

c152a04

feat(contribution-form): show form errors when a field is touched and…

a7d2426

… invalid

feat(contribution-form): find global error manually depending on each…

2501aa7

… fields state

chore(contribution-form): remove unused prop

69de70e

chore(contribution-form): move form related side effects to condition

9edb128

chore(contribution-form): fix requiredPaths typing

6a93b21

chore(form): rename Errors model to ValidationErrors

b06a690

chore(contribution-form): add space between preview buttons

710e252

fix(contribution): show contributor name on preview screen

45352cb

fix(contribution): fix global error not showing up anymore on the pre…

b5e4d31

…view screen if submission failed

chore(contribution): update lockfile after rebase

4a17a7e

style(contribution): fix typing issue

b95b018

try to clarify getFlatFormErrors fix typings issues functional style to validateContribution

lutangar force-pushed the style/EmbeddedContributionForm branch from 978ecfc to b95b018 Compare September 6, 2019 14:44

lutangar merged commit 111d5e2 into develop Sep 12, 2019

bmenant deleted the style/EmbeddedContributionForm branch October 11, 2019 10:38

bmenant added the released label Oct 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Embedded contribution form #325

Embedded contribution form #325

newick commented Jun 14, 2019

JalilArfaoui commented Jun 14, 2019

JalilArfaoui commented Jun 20, 2019

bmenant commented Jun 25, 2019 •

edited

Loading

lutangar commented Aug 5, 2019

JalilArfaoui left a comment

JalilArfaoui left a comment

JalilArfaoui Aug 15, 2019

lutangar Aug 16, 2019

JalilArfaoui Aug 16, 2019 •

edited

Loading

lutangar Aug 16, 2019 •

edited

Loading

JalilArfaoui Aug 16, 2019

lutangar Sep 6, 2019

lutangar Sep 6, 2019

lutangar Sep 6, 2019

lutangar Sep 6, 2019

bmenant commented Oct 11, 2019

		@@ -1,4 +1,4 @@
		import { PersistedState } from 'redux-persist/es/types';

Embedded contribution form #325

Embedded contribution form #325

Conversation

newick commented Jun 14, 2019

JalilArfaoui commented Jun 14, 2019

JalilArfaoui commented Jun 20, 2019

bmenant commented Jun 25, 2019 • edited Loading

lutangar commented Aug 5, 2019

JalilArfaoui left a comment

Choose a reason for hiding this comment

Some functional comments:

JalilArfaoui left a comment

Choose a reason for hiding this comment

JalilArfaoui Aug 15, 2019

Choose a reason for hiding this comment

lutangar Aug 16, 2019

Choose a reason for hiding this comment

JalilArfaoui Aug 16, 2019 • edited Loading

Choose a reason for hiding this comment

lutangar Aug 16, 2019 • edited Loading

Choose a reason for hiding this comment

JalilArfaoui Aug 16, 2019

Choose a reason for hiding this comment

lutangar Sep 6, 2019

Choose a reason for hiding this comment

lutangar Sep 6, 2019

Choose a reason for hiding this comment

lutangar Sep 6, 2019

Choose a reason for hiding this comment

lutangar Sep 6, 2019

Choose a reason for hiding this comment

bmenant commented Oct 11, 2019

bmenant commented Jun 25, 2019 •

edited

Loading

JalilArfaoui Aug 16, 2019 •

edited

Loading

lutangar Aug 16, 2019 •

edited

Loading